Skip to content

refactor: move identity DEFAULT_MOUNT_POINT to constants #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2024
Merged

refactor: move identity DEFAULT_MOUNT_POINT to constants #1123

merged 2 commits into from
Jan 20, 2024

Conversation

cognifloyd
Copy link
Contributor

Extracted some minor refactors from #1118

@cognifloyd cognifloyd requested a review from a team as a code owner January 2, 2024 16:21
@cognifloyd cognifloyd changed the title refacotr: move identity DEFAULT_MOUNT_POINT to constants refactor: move identity DEFAULT_MOUNT_POINT to constants Jan 2, 2024
@cognifloyd cognifloyd mentioned this pull request Jan 2, 2024
Open
@cognifloyd
Copy link
Contributor Author

@briantist Could you review this minor refactor please?

@briantist briantist self-assigned this Jan 20, 2024
@briantist briantist added secrets engines generally related to a Vault secrets engine identity Identity secrets engine; identity management solution for Vault misc Used as a release-drafter "category" patch Used as part of release-drafter's version-resolver configuration maintenance General technical debt labels Jan 20, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26bb929) 87.38% compared to head (ac81d6f) 87.38%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1123   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          66       66           
  Lines        3227     3227           
=======================================
  Hits         2820     2820           
  Misses        407      407
Files Coverage Δ
hvac/api/auth_methods/okta.py 100.00% <ø> (ø)
hvac/api/secrets_engines/identity.py 93.98% <100.00%> (-0.03%) ⬇️
hvac/constants/identity.py 100.00% <100.00%> (ø)

briantist
briantist approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cognifloyd ! This looks good to me.

@briantist briantist merged commit f7688e2 into hvac:main Jan 20, 2024
@cognifloyd cognifloyd deleted the loginmfa-prep branch January 20, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantist briantist briantist approved these changes

Assignees

@briantist briantist

Labels
identity Identity secrets engine; identity management solution for Vault maintenance General technical debt misc Used as a release-drafter "category" patch Used as part of release-drafter's version-resolver configuration secrets engines generally related to a Vault secrets engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognifloyd @briantist