add tuning params to tune_secret_backend method #215
Conversation
|
Looks reasonable, thanks! Just need to clear up these python 2.7 flake8 violations and then we can get this merged:
|
|
My bad, should be ok now ! |
hvac/v1/__init__.py
Outdated
| if locals().get(optional_parameter) is not None: | ||
| params[optional_parameter] = locals().get(optional_parameter) | ||
| return self._post('/v1/sys/mounts/{0}/tune'.format(mount_point), | ||
| json=params) |
There was a problem hiding this comment.
Super tiny thing, but could you move this json=params) bit of the call to the previous line (unless there is some compelling reason to include the line break)? Aside from that things look ready to merge.
.gitignore
Outdated
| @@ -1,4 +1,6 @@ | |||
| .DS_Store | |||
| .python-version | |||
| .idea | |||
There was a problem hiding this comment.
Oh and I'd rather leave this sort of .gitignore addition out of this repository. While I totally use pycharm, there isn't any reason to assume what IDE / editor contributors may be using. For gitignore entries unique to your development environment, I recommend simply using a "global" gitignore file instead: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
Would you mind backing out these changes?
Add all supported tuning parameters to tune_secret_backend method the same way than tune_auth_backend method
Add all supported tuning parameters to tune_secret_backend method the same way than tune_auth_backend method