Skip to content

Breakout Requests Functionality to New Adapter Module #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 19, 2018
Merged

Breakout Requests Functionality to New Adapter Module #223

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
81c6fe1
Include class constructors with autodoc modules
Jul 16, 2018
2e36e8a
add breaking changes section
Jul 16, 2018
8bc0c97
Add adapters and utils modules
Jul 16, 2018
203fc10
Move client class to use adapters.Request
Jul 16, 2018
3fffbe1
Merge remote-tracking branch 'upstream/master' into adapter_pattern
Jul 16, 2018
3df8412
Expand raise_for_error docstring
Jul 16, 2018
1e57318
Clarify purpose of newly added sphinx conf skip() method
Jul 16, 2018
2dd7117
Fewer line breaks
Jul 16, 2018
7d289a6
Clarify language
Jul 16, 2018
e4c49cf
Add initial guide/documentation around new adapter module
Jul 18, 2018
04116de
Migrate last requests call out of Client class and into aws_utils
Jul 18, 2018
3a92e78
Update put call in recently added read_lease method
Jul 18, 2018
4828420
versionadded notes and link to requests module
Jul 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify language
  • Loading branch information
Jeffrey Hogan committed Jul 16, 2018
commit 7d289a64292ae07d6146e16073a731a2af91027b
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

BACKWARDS COMPATIBILITY NOTICE:

* With the newly added `hvac.adapters.Request` class, request kwargs can no longer be directly modified via the `_kwargs` attribute on the `Client` class. If runtime modifications to this dictionary are required, callers either need to explictly update the `adapter` propery on the `Client` class or access the `_kwargs` property via the `adapter` property on the `Client` class.
* With the newly added `hvac.adapters.Request` class, request kwargs can no longer be directly modified via the `_kwargs` attribute on the `Client` class. If runtime modifications to this dictionary are required, callers either need to explicitly pass in a new `adapter` instance with the desired settings via the `adapter` propery on the `Client` class *or* access the `_kwargs` property via the `adapter` property on the `Client` class.

IMPROVEMENTS:

Expand Down