Send token as a param, to avoid token been logged by the audit log #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by the audit log
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 12 12
Lines 1014 1014
=======================================
Hits 898 898
Misses 116 116
|
jeffwecan
reviewed
Aug 22, 2018
hvac/v1/__init__.py
Outdated
| @@ -946,11 +946,11 @@ def renew_token(self, token=None, increment=None, wrap_ttl=None): | |||
| """ | |||
| params = { | |||
| 'increment': increment, | |||
| 'token': token, | |||
There was a problem hiding this comment.
Perhaps it makes more sense to move setting this token key in the params dict to under the following conditional? I.e., no need to send it in the params if we're doing the renew-self call:
def renew_token(self, token=None, increment=None, wrap_ttl=None):
params = {
'increment': increment,
}
if token is not None:
params['token'] = token
return self._adapter.post('/v1/auth/token/renew', json=params, wrap_ttl=wrap_ttl).json()
else:
return self._adapter.post('/v1/auth/token/renew-self', json=params, wrap_ttl=wrap_ttl).json()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token should be sent as a parameter in a POST request to the renew endpoint. This will avoid token getting logged in an audit logs, it will also comply with current vault API policy (a warning is produced when token is sent as a URL parameter).
Using a token in the path is unsafe as the token can be logged in many places. Please use POST or PUT with the token passed in via the "token" parameter.