Skip to content

Fix az list roles #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2019
Merged

Fix az list roles #448

merged 5 commits into from
May 25, 2019

Conversation

drewmullen
Copy link
Member

@drewmullen drewmullen commented May 24, 2019

this is a fix for #447 in reference to hashicorp/vault#6785

with s

python azure_auth_role.py

Traceback (most recent call last):
  File "azure_auth_role.py", line 33, in <module>
    main()
  File "azure_auth_role.py", line 13, in main
    print(client.auth.azure.list_roles(mount_point='azure'))
  File "/Users/dmullen/venv/lib/python3.7/site-packages/hvac/api/auth_methods/azure.py", line 205, in list_roles
    url=api_path
  File "/Users/dmullen/venv/lib/python3.7/site-packages/hvac/adapters.py", line 145, in list
    return self.request('list', url, **kwargs)
  File "/Users/dmullen/venv/lib/python3.7/site-packages/hvac/adapters.py", line 276, in request
    utils.raise_for_error(response.status_code, text, errors=errors)
  File "/Users/dmullen/venv/lib/python3.7/site-packages/hvac/utils.py", line 36, in raise_for_error
    raise exceptions.InvalidPath(message, errors=errors)
hvac.exceptions.InvalidPath: 1 error occurred:
        * unsupported path

without s

python azure_auth_role.py
{'keys': ['test']}

Jeffrey Hogan and others added 2 commits May 23, 2019 20:35
@drewmullen
Copy link
Member Author

must have borked a test somewhere. ill investigate tuesday, unless you happen to know what it is... :D

@jeffwecan jeffwecan added this to the 0.9.1 milestone May 25, 2019
@codecov-io
Copy link

codecov-io commented May 25, 2019

Codecov Report

Merging #448 into develop will increase coverage by 0.65%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
+ Coverage    86.91%   87.56%   +0.65%     
===========================================
  Files           49       50       +1     
  Lines         2529     2654     +125     
===========================================
+ Hits          2198     2324     +126     
+ Misses         331      330       -1
Impacted Files Coverage Δ
hvac/api/auth_methods/azure.py 100% <100%> (+1.69%) ⬆️
hvac/api/secrets_engines/__init__.py 100% <0%> (ø) ⬆️
hvac/api/secrets_engines/pki.py 100% <0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants