fix typo in kubernetes list_role api call #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmullen
reviewed
Jun 7, 2019
|
Thanks man! Have a good weekend |
jeffwecan
pushed a commit
that referenced
this pull request
Jun 8, 2019
* bound_resource_groups not _names * bound_location -> locations * include num_uses param * include db engine as implemented class * fix delete_con and include mount_point var include mount_point doc flake8 * fixes for create_role function * fix delete_role return statement * fix reset_connection return statement * educated guess that this doesnt return json object * flake8 fixes * Enable the consul secret engine * Add custom mount point and remove json method when it's not possible * Add slack notifications secret to travis CI config * Add gitter notification config to codecov.yaml * Add gitter webhooks to travis config * Add gitter badge * Drop a note about gitter room in contributing doc as well * add param to tune_mount_configuration * include kwargs arg for tuning kwargs flake8 * include kwargs in docstring * fix typo in kubernetes list_role api call (#466) * fix typo in kubernetes list_role api call * fix kubernetes list_roles tests * Update example policy docs * Add example for vault agent socket listener * bonus TOC * Update adapter param behavior to match docs (by making it a class) (#469) * Changelog updates for v0.9.2 release * Bump version: 0.9.1 → 0.9.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #438