Dump TRIGGER definitions _after_ data #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new CSV output mode with the concept of "output drivers" was added in #92, dumping
TRIGGERdefinitions was made an implementation detail of the MySQL output driver. This causedTRIGGERdefinitions to be dumped right after theCREATE TABLE ...commands, before the actual dataINSERTstatements.This potentially breaks the generated SQL files, since a newly created trigger may be relevant for the subsequent
INSERTstatements; however, MySQL requires that tables used in the trigger are also included in theLOCK TABLESstatements.The aim of this PR is to revert that change, i. e. to dump trigger definitions for a table after the data insert statements for it.
I think it is not necessary to move all trigger definitions to the very end of the output – that is, after all tables have been created and filled with data: A trigger depends on insert/update/deletes for a particular table and is executed only on these events. So, it is not a problem if a trigger refers to a table that has not been created/loaded yet as long as the trigger is not run (and avoiding to run it is the aim of this PR).