Skip to content

Add support for opacity to XRCompositionLayer #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2022
Merged

Add support for opacity to XRCompositionLayer #284

merged 5 commits into from
Jul 11, 2022

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented Jun 14, 2022 •
edited by pr-preview bot
Loading

@cabanier
Copy link
Member Author

Fixed #283

@cabanier cabanier requested review from Manishearth and toji June 15, 2022 02:51
toji
toji approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I forgot to give this a review earlier.

@cabanier cabanier merged commit be036d5 into immersive-web:main Jul 11, 2022
@cabanier cabanier deleted the opacity branch July 11, 2022 17:42
github-actions bot added a commit that referenced this pull request Jul 11, 2022
@cabanier @github-actions
Merge pull request #284 from cabanier/opacity
506c7cb 
SHA: be036d5
Reason: push, by @cabanier

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 12, 2022
@cabanier @github-actions
Merge pull request #284 from cabanier/opacity
603d47c 
SHA: be036d5
Reason: push, by @himorin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 16, 2022
@cabanier @github-actions
Merge pull request #284 from cabanier/opacity
cfb38e5 
SHA: be036d5
Reason: push, by @himorin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jul 19, 2022
@cabanier @github-actions
Merge pull request #284 from cabanier/opacity
c8ac3a8 
SHA: be036d5
Reason: push, by @himorin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eXponenta eXponenta mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

@Manishearth Manishearth Awaiting requested review from Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabanier @toji