Defer initial inputsourcechange event till after the promise resolves #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabanier
reviewed
Apr 21, 2020
| @@ -382,6 +382,13 @@ When this method is invoked, the user agent MUST run the following steps: | |||
| <dd> Append |session| to the [=list of inline sessions=]. | |||
| </dl> | |||
| 1. [=/Resolve=] |promise| with |session|. | |||
| 1. [=Queue a task=] to perform the following steps: | |||
There was a problem hiding this comment.
Does the Resolve step wait until the task is done?
There was a problem hiding this comment.
It's the other way around, resolve uses a microtask, and queue a task uses a regular task, so we can guarantee that the callback attached in requestSession(..).resolve(callback) will execute before the task below does.
There was a problem hiding this comment.
ok. Resolve actually calls the then function. I think this looks good!
There was a problem hiding this comment.
Yep!
er, i should have written then instead of resolve in my comment above, but you get the idea
toji
approved these changes
Apr 21, 2020
|
@klausw you might want to ensure the impl in chrome does this deferring properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
As mentioned in #961, this is not the only way to fix this issue; the other way to fix it involves changing the spec so that
inputSourcescan start off non-null, however that involves ensuring the ecosystem respects that as well.r? @toji
cc @cabanier