Clarify threading nature of "ensure an immersive device is selected", deprecate xrCompatible #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toji
reviewed
Jun 12, 2020
Manishearth
force-pushed
the
ensure-parallel
branch
from
999c108 to
3e894b5
Compare
|
Addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1036 by making sure "ensure an immersive device is selected" is only called in parallel, and deprecating
xrCompatibledue to slow sync behavior.This fixes #1044 by specifying the behavior of the flag the same way WebGL does, as opposed to patching the HTML spec.