Only allow sessions to use features they explicity request or are implicitly granted based on mode #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 30, 2021
|
This looks like a good change. Do we know if this is compatible with current implementations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, features would "carry over" between XR sessions for the same web page, which can lead to sessions unpredictably being granted features they did not ask for.
With this change, sessions may only use features they have explicitly requested. Previously granted features are still used to skip consent prompts, but must be explicitly requested on session creation.
Note: prior to this PR, the experimental not-yet-implemented Permissions Request API could have been used for mid session feature requests. That is no longer the case and we need to add an API to reenable this if we wish (#1190).
Fixes #1178
Preview | Diff