Changed XRHandedness enum to use 'none' instead of '' #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NellWaliczek
approved these changes
Feb 19, 2019
|
As an aside, I'm inclined to change the gamepad mapping stuff I've been working on to say "none" instead of "neutral" to keep in sync. Yell if you object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #515.
Thanks to @HyroVitalyProtago for the suggestion! Empty string was definitely a weird enum, and so I do feel like it's appropriate to change it to a more representative string. I had suggested
neutralin the issue, but upon thinking it through further I feel like @HyroVitalyProtago's original suggestion ofnoneis more appropriate. This is because the input in question may not actually be associated with any hand at all, such as is the case with gaze input, whereasneutralimplies to me that the input is actually associated with a hand but doesn't know or care which. i.e: A Vive wand that hasn't established it's spatial relationship yet strikes me as a "neutral" input device, while a cardboard device has no hand association whatsoever. In both casesnonefeels like an appropriate descriptor of the handedness.