Spec: Stationary subtype support is all-or-nothing #537
Conversation
index.bs
Outdated
| @@ -765,6 +765,8 @@ There are several subtypes of {{XRStationaryReferenceSpace}}, determined by the | |||
|
|
|||
| Note: The {{position-disabled}} subtype is primarily intended for use with pre-rendered media such as panoramic photos or videos. It should not be used for most other media types due to user discomfort associated with the lack of a neck model or full positional tracking. | |||
|
|
|||
| Devices which support {{XRReferenceSpaceType/stationary}} reference spaces MUST support all {{XRStationaryReferenceSpace/subtype}}s. | |||
index.bs
Outdated
| @@ -749,6 +743,12 @@ XRStationaryReferenceSpace {#xrstationaryreferencespace-interface} | |||
| An {{XRStationaryReferenceSpace}} represents a tracking space that the user is not expected to move around within. Tracking in a {{stationary}} reference space is optimized for the assumption that the user will not move much beyond their starting point, if at all. For devices with [=6DoF=] tracking, {{stationary}} reference spaces should emphasize keeping the origin stable relative to the user's environment. | |||
|
|
|||
| <pre class="idl"> | |||
| enum XRStationaryReferenceSpaceSubtype { | |||
There was a problem hiding this comment.
Regarding #532:
This change moves the IDL closer to the definition it will link to. However, these values are most relevant in XRSession, and the definitions actually describe the behavior of values passed to XRSession::requestReferenceSpace() (as part of XRReferenceSpaceOptions). As noted in #532, it probably makes sense to move the definitions/prose and IDL (including other things like XRReferenceSpaceOptions to XRSession.
index.bs
Outdated
| @@ -765,6 +765,8 @@ There are several subtypes of {{XRStationaryReferenceSpace}}, determined by the | |||
|
|
|||
| Note: The {{position-disabled}} subtype is primarily intended for use with pre-rendered media such as panoramic photos or videos. It should not be used for most other media types due to user discomfort associated with the lack of a neck model or full positional tracking. | |||
|
|
|||
| Devices which support {{XRReferenceSpaceType/stationary}} reference spaces MUST support all {{XRStationaryReferenceSpace/subtype}}s. | |||
There was a problem hiding this comment.
I think you want to replace
{{XRStationaryReferenceSpace/subtype}}s
with
{{XRStationaryReferenceSpaceSubtype}} values
There was a problem hiding this comment.
Thanks for adding this. I'm also inclined towards David's point that the reference space options should be defined near the function that receives them (especially in light of not wanting to have an XRReferenceSpace attribute reflecting the requested values).
|
Thanks David and Nell! Addressed both of David's nits and moved the subtype description up in the file. PTAL! |
Fixes #532 and #533