Second try @ Remove context Attribute from XRWebGLLayer #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea what I'm doing so I'll explain what I did. I made what seemed like the obvious change in index.bs and tried to find any other references in the file. I searched through the explainer to see if it needed changes and it didn't seem to. I also checked a few of the code samples and they also don't seem to us this attribute.
This was referenced Jun 15, 2019
Manishearth
approved these changes
Jun 15, 2019
| @@ -1600,6 +1598,8 @@ interface XRWebGLLayer { | |||
| }; | |||
| </pre> | |||
|
|
|||
| Each {{XRWebGLLayer}} has a <dfn for="XRWebGLLayer">context</dfn> object, initially <code>null</code>, which is an instance of either a {{WebGLRenderingContext}} or a {{WebGL2RenderingContext}}. | |||
There was a problem hiding this comment.
You can just say that this is an {{XRWebGLRenderingContext}} (but you don't have to, this is fine too)
There was a problem hiding this comment.
I think this is actually slightly clearer in this case, since it avoids the need to cross-reference with other parts of the spec. Since it's not a huge difference in the size of the text, nor is it something that gets repeated a lot elsewhere, I'm good with it.
|
Perfect, thanks! (And let me know if you want a mini tutorial on updating an existing PR sometime! It's not hard, but it's a process that likes to throw intimidating error messages at you that you.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redo of #699 since I made some mistakes in that one I am not sure how to fix.
I think it addressed the comments on that PR