Potentially update the inline device when the device changes #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry I've missed reviewing this for so long! Yes, this was definitely my intent and it's good to have it stated explicitly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was kind of missed in #737
Basically, if the user "switches into" viewing the page on an immersive XR device after the page has already loaded, inline sessions should be able to use and request tracking.
This does mean you can request an inline session while viewing the page in immersive mode, remove and disconnect the headset, and then have an inline session that was previously allowed to use tracking spaces but no longer can. This is a bit of a weird wrinkle but I think in the current situation it will just refuse to return poses, which is fine.
r? @toji