Skip to content

Potentially update the inline device when the device changes #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

Manishearth
Copy link
Contributor

This was kind of missed in #737

Basically, if the user "switches into" viewing the page on an immersive XR device after the page has already loaded, inline sessions should be able to use and request tracking.

This does mean you can request an inline session while viewing the page in immersive mode, remove and disconnect the headset, and then have an inline session that was previously allowed to use tracking spaces but no longer can. This is a bit of a weird wrinkle but I think in the current situation it will just refuse to return poses, which is fine.

r? @toji

@toji toji added this to the Pre-CR milestone Jan 6, 2020
@toji
Copy link
Member

toji commented Jan 24, 2020

I'm sorry I've missed reviewing this for so long! Yes, this was definitely my intent and it's good to have it stated explicitly.

@toji toji merged commit de9edc0 into immersive-web:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants