Rename IGetAllScheduleInfo to IGetScheduleInfo #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll references Co-authored-by: jamesmh <7213174+jamesmh@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
jamesmh
July 10, 2025 02:24
There was a problem hiding this comment.
Pull Request Overview
This PR renames the interface IGetAllScheduleInfo to IGetScheduleInfo to better align the interface name with its actual purpose of providing information about a single schedule rather than all schedules.
- Renamed interface from
IGetAllScheduleInfotoIGetScheduleInfo - Updated implementation in
ScheduledEventclass - Updated usage in
Scheduler.GetSchedules()method
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IGetScheduleInfo.cs | Interface renamed from IGetAllScheduleInfo to IGetScheduleInfo |
| ScheduledEvent.cs | Updated to implement the renamed IGetScheduleInfo interface |
| Scheduler.cs | Updated to use IGetScheduleInfo in the GetSchedules() method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the interface
IGetAllScheduleInfotoIGetScheduleInfoto better reflect its actual purpose and usage.Changes Made
IGetAllScheduleInfo.cstoIGetScheduleInfo.csIGetAllScheduleInfotoIGetScheduleInfoScheduledEvent.csto implementIGetScheduleInfoScheduler.csto useIGetScheduleInfoin theGetSchedules()methodRationale
The original name
IGetAllScheduleInfowas misleading because:GetScheduleInfo()that returns information about one scheduleScheduler.GetSchedules()method which calls this interface on individual schedule eventsIGetScheduleInfomore accurately represents what the interface doesTesting
All existing tests continue to pass:
No breaking changes were introduced as this is purely an internal interface rename.
Fixes #444.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.