-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update Ruby to 3.3.7 #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Ruby to 3.3.7 #1191
Conversation
WalkthroughThe Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.ruby-version (1)
1-1
: ```shell
#!/bin/bash
set +eecho "🔍 Locating all Dockerfile variants:"
mapfile -t files < <(find . -type f -iname 'dockerfile*')
if [ ${#files[@]} -eq 0 ]; then
echo "⚠️ No Dockerfiles found."
else
printf "%s\n" "${files[@]}"
for f in "${files[@]}"; do
echo "==> Inspecting $f"
rg -n '^FROM ruby:' "$f" || echo " - no Ruby base image in $f"
done
fiecho
echo "🔍 Checking GitHub workflows for ruby/setup-ruby usage and ruby-version:"
rg -n -C2 'uses:.ruby/setup-ruby' .github/workflows/.yml || echo " - no ruby/setup-ruby usages found"
rg -n 'ruby-version:' .github/workflows/*.yml || echo " - no explicit ruby-version found in workflows"echo
echo "🔍 Scanning Markdown docs for Ruby version references:"
rg -n 'ruby version' -i -g '*.md' || echo " - no Ruby version mentions in docs"</blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** **Plan: Pro** <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 50eab27eb2833dbf910ed4c79651bc1213c8a743 and c9be90f586f16c6145fbd5744174b5ce0ec00c90. </details> <details> <summary>⛔ Files ignored due to path filters (1)</summary> * `Gemfile.lock` is excluded by `!**/*.lock` </details> <details> <summary>📒 Files selected for processing (1)</summary> * `.ruby-version` (1 hunks) </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
I updated ruby from 2.5 to 3.3.7
it has some problems even working in docker gem install bundler is not compatible with ruby 2.5 as instructed in contribute.md I will take care of this in another pr
Summary by CodeRabbit