Fix argument ordering issue when number of arguments exceeds 10. Added test for issue. (#588)

jdhiser · web-flow · commit 9c2112163822 · 2020-05-19T10:46:06.000-04:00
Co-authored-by: Jason Hiser &lt;jdhiser@gmail.com&gt;
diff --git a/lib/launcher.js b/lib/launcher.js
@@ -18,7 +18,7 @@ process.argv.slice(2).forEach(function (arg) {
   if (name === '--spectron-path') {
     executablePath = value
   } else if (name.indexOf('--spectron-arg') === 0) {
-    appArgs.push(value)
+    appArgs[Number(name.substring(14))] = value
   } else if (name.indexOf('--spectron-env') === 0) {
     process.env[name.substring(15)] = value
   } else if (name.indexOf('--spectron-') !== 0) {
diff --git a/test/many-args.js b/test/many-args.js
@@ -0,0 +1,57 @@
+var helpers = require('./global-setup')
+var path = require('path')
+var temp = require('temp').track()
+
+var describe = global.describe
+var it = global.it
+var beforeEach = global.beforeEach
+var afterEach = global.afterEach
+var expect = require('chai').expect
+
+describe('application loading', function () {
+  helpers.setupTimeout(this)
+
+  var app = null
+  var tempPath = null
+
+  beforeEach(function () {
+    tempPath = temp.mkdirSync('spectron-temp-dir-')
+
+    return helpers.startApplication({
+      cwd: path.join(__dirname, 'fixtures'),
+      args: [
+        path.join(__dirname, 'fixtures', 'app'),
+        '--bar1=baz1',
+        '--bar2=baz2',
+        '--bar3=baz3',
+        '--bar4=baz4',
+        '--bar5=baz5',
+        '--bar6=baz6',
+        '--bar7=baz7',
+        '--bar8=baz8',
+        '--bar9=baz9',
+        '--bar10=baz10',
+        '--bar11=baz11',
+        '--bar12=baz12',
+        '--bar13=baz13'
+      ],
+      env: {
+        FOO: 'BAR',
+        HELLO: 'WORLD',
+        SPECTRON_TEMP_DIR: tempPath
+      }
+    }).then(function (startedApp) { app = startedApp })
+  })
+
+  afterEach(function () {
+    return helpers.stopApplication(app)
+  })
+
+  it('passes through args to the launched app', function () {
+    return app.mainProcess.argv().then(function (argv) {
+      expect(argv[2]).to.equal('--bar1=baz1')
+      expect(argv[9]).to.equal('--bar8=baz8')
+      expect(argv[12]).to.equal('--bar11=baz11')
+    })
+  })
+})
