Skip to content

code-generator/register-gen: groupName can't override #100738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

code-generator/register-gen: groupName can't override #100738

merged 1 commit into from
Aug 5, 2021

Conversation

cuisongliu
Copy link
Contributor

@cuisongliu cuisongliu commented Apr 1, 2021 •
edited by sttts
Loading

Signed-off-by: cuisongliu cuisongliu@qq.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

when I use code-generator to generator code . at doc.go add Comments // +groupName=xxx ,I found not override this groupName.
types.ExtractCommentTags("+", pkg.DocComments)["groupName"] fix to types.ExtractCommentTags("+", pkg.Comments)["groupName"] is right

NONE

@cuisongliu
code-generator/register-gen: groupName can't use '// +groupName=someg…
68ec18a 
…roup ' to override

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @cuisongliu!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cuisongliu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/code-generation sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 1, 2021
@caesarxuchao
Copy link
Member

/assign @sttts
thanks!

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 1, 2021
@cuisongliu
Copy link
Contributor Author

/cc @sttts @lavalamp @wojtek-t

@k8s-ci-robot k8s-ci-robot requested a review from sttts April 16, 2021 08:26
@cuisongliu cuisongliu mentioned this pull request Jun 25, 2021
Closed
sttts
sttts reviewed Jul 16, 2021
View reviewed changes
staging/src/k8s.io/code-generator/cmd/register-gen/generators/packages.go
@@ -82,7 +82,7 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat

// if there is a comment of the form "// +groupName=somegroup" or "// +groupName=somegroup.foo.bar.io",
// extract the fully qualified API group name from it and overwrite the group inferred from the package path
if override := types.ExtractCommentTags("+", pkg.DocComments)["groupName"]; override != nil {
if override := types.ExtractCommentTags("+", pkg.Comments)["groupName"]; override != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does Comments contain all comments? Note, we have this strange distinction between comments directly above something and those separated by an empty line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ic, Comments means all:

// All comments from doc.go, if any.
// TODO: remove Comments and use DocComments everywhere.
Comments []string

Do we have other places like that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I see the other 6 code snippets accessing groupName are fine, just this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I fount this bug just this code . other code is right.

@sttts
Copy link
Contributor

sttts commented Jul 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2021
@sttts
Copy link
Contributor

sttts commented Jul 16, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cuisongliu, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@zhangxiaoyu-zidif
Copy link
Contributor

image
because your PR is not part of v1.22, it's pending. Wait for the latest version release, it will be merged automatically.

@dims
Copy link
Member

dims commented Aug 5, 2021

/release-note-none
/ok-to-test

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 5, 2021
@cuisongliu
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 01d2ee8 into kubernetes:master Aug 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 5, 2021
@cuisongliu cuisongliu deleted the bug_register-gen_groupName branch August 5, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@cuisongliu @k8s-ci-robot @caesarxuchao @sttts @zhangxiaoyu-zidif @dims