Skip to content

chore(): Use k8s 1.32 client libs #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(): Use k8s 1.32 client libs #249

wants to merge 1 commit into from

Conversation

tamalsaha
Copy link
Contributor

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.

Does this PR introduce a breaking change for other components like worker-operator?

@tamalsaha tamalsaha force-pushed the k132 branch 2 times, most recently from 05748a0 to e0cb52a Compare June 4, 2025 20:01
@gourishkb
Copy link
Contributor

Hey @tamalsaha did you run make build ? there are errors with your changes.

kubeslice-controller/apis/controller/v1alpha1/cluster_webhook.go:53:2: invalid field type: interface{GroupVersionKindFor(obj k8s.io/apimachinery/pkg/runtime.Object) (k8s.io/apimachinery/pkg/runtime/schema.GroupVersionKind, error); IsObjectNamespaced(obj k8s.io/apimachinery/pkg/runtime.Object) (bool, error); RESTMapper() k8s.io/apimachinery/pkg/api/meta.RESTMapper; Scheme() *k8s.io/apimachinery/pkg/runtime.Scheme; sigs.k8s.io/controller-runtime/pkg/client.Reader; sigs.k8s.io/controller-runtime/pkg/client.Writer; sigs.k8s.io/controller-runtime/pkg/client.StatusClient; sigs.k8s.io/controller-runtime/pkg/client.SubResourceClientConstructor}

@tamalsaha tamalsaha force-pushed the k132 branch 2 times, most recently from c41d9d4 to 01d76b7 Compare June 6, 2025 08:20
@tamalsaha
Copy link
Contributor Author

I was just using go install -v ./... which was working ok. make build should be ok now.

@tamalsaha
chore(): Use k8s 1.32 client libs
733b0dc 
Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narmidm narmidm Awaiting requested review from narmidm narmidm is a code owner

@priyank-upadhyay priyank-upadhyay Awaiting requested review from priyank-upadhyay priyank-upadhyay is a code owner

@that-backend-guy that-backend-guy Awaiting requested review from that-backend-guy that-backend-guy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamalsaha @gourishkb