feat(BA-1289): Allow anonymous users register TOTP key #4354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:S
github-actions
bot
added
size:M
Comment on lines
72
to
74
| AuthAuthResponseType = ( | ||
| AuthSuccessResponse | RequireTwoFactorRegistrationResponse | RequireTwoFactorAuthResponse | ||
| ) |
There was a problem hiding this comment.
This type doesn't seem necessary.
HyeockJinKim
approved these changes
May 28, 2025
HyeockJinKim
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4324 (BA-1289)
Auth Flow
1. First login trial
Call
POST <WEBSERVER_ENDPOINT>/server/loginResponse JSON data is like below
{ "authenticated": false, "data": { "type": "https://api.backend.ai/probs/require-totp-registration", "title": "Two-Factor Authentication registration required.", "details": "You must register Two-Factor Authentication.", "two_factor_registration_token": "eyJh..." } }2. TOTP activate
Call
POST <WEBSERVER_ENDPOINT>/func/totp/anonAPI with JSON data below{ "registration_token": "eyJh..." }Response JSON data is like below
{ "totp_key": "5ES3...", "totp_uri": "..." }3. After Register TOTP key - Login retry
Call
POST <WEBSERVER_ENDPOINT>/server/loginResponse JSON data is like below
{ "authenticated": false, "data": { "type": "https://api.backend.ai/probs/require-totp-authentication", "title": "Two-Factor Authentication needed.", "details": "You must authenticate using Two-Factor Authentication." } }Checklist: (if applicable)