feat(BA-1443): backend.ai mgr scheduler last-execution-time command
#4507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:M
Comment on lines
+48
to
+57
| @click.argument("scheduler_name", required=False) | ||
| @click.pass_obj | ||
| def last_execution_time( | ||
| cli_ctx: CLIContext, | ||
| scheduler_name: str | None, | ||
| *, | ||
| format: Literal["plain"] | Literal["csv"] | Literal["json"] = "plain", | ||
| manager_id: str | None = None, | ||
| ) -> None: | ||
| """Queries manager's scheduler execution footprint from Redis. When scheduler name is not specified, this command will return informations of all schedulers in store.""" |
There was a problem hiding this comment.
It seems like last_execution_time returns more information than the name.
Would footprint be a better name?
There was a problem hiding this comment.
"footprint" looks good, perhaps we can count more generic term like "information".
HyeockJinKim
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4506 (BA-1443). This PR adds new command set to manager CLI implementation (not
client-py).The command accepts
scheduler_name, which refers target scheduler name to look up, and--manager-id, which defines which manager node to fetch information of, being set as the local manager executing the command by default. When not specifyingscheduler_name` argument, the command will return status of every schedulers operated from the target manager node. On a complicated cluster with multiple active Backend.AI managers operating concurrently, Backend.AI keeps track of each manager node's last execution time of each scheduler locally, not on a global redis key namespace, hence requiring CLI users to fetch status of each manager individually.Checklist: (if applicable)