fix: idle checker init arguments #4557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:M
There was a problem hiding this comment.
Pull Request Overview
This PR refactors idle checker initialization by removing obsolete constructor parameters from NewUserGracePeriodChecker, introducing a unified BaseIdleChecker constructor for dependency injection, and updating checker instantiation to include the new db argument.
- Removed event dispatcher and Redis args from
NewUserGracePeriodCheckerinit - Added
__init__with dependencies toBaseIdleCheckerand updated subclasses - Updated
init_idle_checkersto passdbto all checker constructors
Comments suppressed due to low confidence (4)
src/ai/backend/manager/idle.py:1288
- The updated checker_init_args now include db; add or update unit tests to verify that all idle checker subclasses are initialized correctly and handle missing/extra arguments as expected.
checker_init_args = (event_dispatcher, checker_host._redis_live, checker_host._redis_stat, db)
src/ai/backend/manager/idle.py:574
- Changing BaseIdleChecker's constructor signature is a breaking change; ensure this API modification is documented in release notes or migration guides.
class BaseIdleChecker(AbstractIdleChecker, AbstractIdleCheckReporter):
src/ai/backend/manager/idle.py:510
- [nitpick] The empty init in NewUserGracePeriodChecker may be redundant; consider removing it or adding a comment to explain its necessity if future initialization logic is expected.
def __init__(self) -> None:
src/ai/backend/manager/idle.py:574
- [nitpick] Class-level declarations of dependency attributes in BaseIdleChecker duplicate the init parameters; consider consolidating to a single definition (e.g., via dataclass or annotations in init) to reduce redundancy.
_event_dispatcher: EventDispatcher
HyeockJinKim
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)
ai.backend.testdocsdirectory