[WEB-1086] chore: update toast messages for consistency. #4384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SatishGandham
approved these changes
May 7, 2024
There was a problem hiding this comment.
Hi Prateek,
Can you move the messages to a common file and use from there. This helps with internationalization in future and one place to look at all messaging if we want to change the tone/language in future.
export const TITLES = {SUCCESS:'Success!'}
export const MESSAGES = {ISSUE_TRANSFER_SUCCESS:'Issues have been transferred successfully'}
@rahulramesha , @sriramveeraghanta What do you think?
Should we nest success,error and pending?
SatishGandham
approved these changes
May 7, 2024
SatishGandham
suggested changes
May 7, 2024
SatishGandham
suggested changes
May 7, 2024
SatishGandham
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on updating toast title for consistency.
Issue link: WEB-1086