Add webextensions.api.tabGroups API
#26724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Rob--W
approved these changes
May 7, 2025
There was a problem hiding this comment.
Approved provided that the following changes are made.
To make it easier to see the result, I used the preview tool I created before, at https://jsbin.com/subipeyibo/edit?html,output
with the following URL as input: https://raw.githubusercontent.com/rebloor/browser-compat-data/Add-tabGroups-API/webextensions/api/tabGroups.json
webextensions/api/tabGroups.json
Outdated
Comment on lines
230
to
250
| }, | ||
| "groupId": { | ||
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "89" | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "139" | ||
| }, | ||
| "firefox_android": { | ||
| "version_added": false | ||
| }, | ||
| "opera": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror" | ||
| } | ||
| } |
There was a problem hiding this comment.
webextensions.api.tabGroups.get.groupId does not need to be documented separately, as it is a core part of the API definition.
Suggested change
| }, | |
| "groupId": { | |
| "__compat": { | |
| "support": { | |
| "chrome": { | |
| "version_added": "89" | |
| }, | |
| "edge": "mirror", | |
| "firefox": { | |
| "version_added": "139" | |
| }, | |
| "firefox_android": { | |
| "version_added": false | |
| }, | |
| "opera": "mirror", | |
| "safari": { | |
| "version_added": false | |
| }, | |
| "safari_ios": "mirror" | |
| } | |
| } |
Co-authored-by: Rob Wu <rob@robwu.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds data for the
webextensions.api.tabGroupsAPI and updates thepermissionsandoptional_permissionskey data for the introduction of thetabGroupspermission.Related issues
webextensions.api.tabGroupsdocumentation content#39370