Add await keyword to some of the examples #38177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebExt
Closed
rebloor
requested changes
Mar 6, 2025
| @@ -12,7 +12,7 @@ Configures whether the action count for tabs is displayed as the extension actio | |||
| ## Syntax | |||
|
|
|||
| ```js-nolint | |||
| let count = browser.declarativeNetRequest.setExtensionActionOptions( | |||
| let count = await browser.declarativeNetRequest.setExtensionActionOptions( | |||
There was a problem hiding this comment.
Where the promise returns with no arguments, the more common approach in the docs is to omit await. (see #38073 (comment))
Suggested change
| let count = await browser.declarativeNetRequest.setExtensionActionOptions( | |
| let settingCount = browser.declarativeNetRequest.setExtensionActionOptions( |
| @@ -23,7 +23,7 @@ Modifies the set of dynamic rules for the extension. The rules with IDs listed i | |||
| ## Syntax | |||
|
|
|||
| ```js-nolint | |||
| let updatedRules = browser.declarativeNetRequest.updateDynamicRules( | |||
| let updatedRules = await browser.declarativeNetRequest.updateDynamicRules( | |||
There was a problem hiding this comment.
Suggested change
| let updatedRules = await browser.declarativeNetRequest.updateDynamicRules( | |
| let rulesUpdated = browser.declarativeNetRequest.updateDynamicRules( |
| @@ -19,7 +19,7 @@ Modifies the set of session-scoped rules for the extension. The rules with IDs l | |||
| ## Syntax | |||
|
|
|||
| ```js-nolint | |||
| let updatedRuleset = browser.declarativeNetRequest.updateSessionRules( | |||
| let updatedRuleset = await browser.declarativeNetRequest.updateSessionRules( | |||
There was a problem hiding this comment.
Suggested change
| let updatedRuleset = await browser.declarativeNetRequest.updateSessionRules( | |
| let rulesetUpsated = browser.declarativeNetRequest.updateSessionRules( |
| @@ -14,7 +14,7 @@ Rules can be enabled and disabled while the ruleset containing them is disabled. | |||
| ## Syntax | |||
|
|
|||
| ```js-nolint | |||
| let updatedStaticRules = browser.declarativeNetRequest.updateStaticRules( | |||
| let updatedStaticRules = await browser.declarativeNetRequest.updateStaticRules( | |||
There was a problem hiding this comment.
Suggested change
| let updatedStaticRules = await browser.declarativeNetRequest.updateStaticRules( | |
| let staticRulesUpdated = browser.declarativeNetRequest.updateStaticRules( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a partial fix to the issue issues#37866. I was planning to review the Browser extensions section and add small fix(content) to it instead of making one huge PR.
Motivation
Like I said before, I honestly love MDN for making information free and open to anyone, and decided to contribute by fixing some of the issues :)
Additional details
issues#37866
Related issues and pull requests
pull#3818