-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Clarification of difference between additional privileges granted in MV2 and MV3 host permissions #39260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rebloor
wants to merge
1
commit into
mdn:main
Choose a base branch
from
rebloor:host-permission-differences-clarification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Open
Clarification of difference between additional privileges granted in MV2 and MV3 host permissions #39260
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a reader, I still find this wording a bit confusing.
The parenthetical sentence contrasts the described behavior with Manifest V2, but it wasn't clear that the first sentence was referring to Manifest V3 in the first place. This is further complicated by the fact that content script behaviors differ across browsers – but lets table this concern for the moment.
I've taken a shot at rewriting this line to be more easily understandable on first read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotproto the manifest version is stated at the top of the page and clearly identifies that this feature is supported in 3 or above. So I don't believe there was a need to reword. The rewording adds ambiguity as it suggests this feature can be used in 2 and 3 but has different behavior in each.