Skip to content

Addition of the webextensions.api.tabGroups documentation #39370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 23, 2025
+579 −6
Merged

Addition of the webextensions.api.tabGroups documentation #39370

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
47d05b8
Addition of the `webextensions.api.tabGroups` documentation
rebloor May 2, 2025
e14dcfb
Update `tabs` API with reference to `tabGroups.TAB_GROUP_ID_NONE`
rebloor May 2, 2025
a717a38
Merge branch 'main' into Add-tabGroups-API
rebloor May 2, 2025
af5f98e
Additional documentation per Chrome
rebloor May 5, 2025
579d0e3
Merge branch 'main' into Add-tabGroups-API
rebloor May 5, 2025
5c91eac
Clarified onMove differences in Chrome
rebloor May 7, 2025
5796ebc
Update files/en-us/mozilla/add-ons/webextensions/api/tabgroups/color/…
rebloor May 8, 2025
7301671
Update files/en-us/mozilla/add-ons/webextensions/api/tabgroups/index.md
rebloor May 8, 2025
1d24f35
Update files/en-us/mozilla/add-ons/webextensions/api/tabgroups/index.md
rebloor May 8, 2025
15513a5
Apply suggestions from review
rebloor May 8, 2025
da46206
Apply suggestions from review
rebloor May 8, 2025
81fa00c
Apply suggestions from review
rebloor May 8, 2025
6e0ea9f
Apply suggestions from review
rebloor May 8, 2025
0542e29
Apply suggestions from review
rebloor May 8, 2025
4ba4715
Apply suggestions from linter
rebloor May 8, 2025
f6e8436
Further feedback changes
rebloor May 8, 2025
1a7bc19
Apply suggestions from review
rebloor May 12, 2025
c581e68
Apply suggestions from review
rebloor May 12, 2025
8959d01
Linter feedback on review changes
rebloor May 12, 2025
65222de
Feedback update updates
rebloor May 14, 2025
200a705
Review feedback
rebloor May 21, 2025
ceef2b5
Remove note about resolved bug
rebloor May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Additional documentation per Chrome
  • Loading branch information
@rebloor
rebloor committed May 5, 2025
commit af5f98eb07e4d7d2e6f392083449b4182c9517a5
4 changes: 3 additions & 1 deletion files/en-us/mozilla/add-ons/webextensions/api/tabgroups/onmoved/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ browser-compat: webextensions.api.tabGroups.onMoved

{{AddonSidebar}}

Fires when a tab group is moved, within a window or to another window.
Fires when a tab group is moved, within a window or to another window. {{WebExtAPIRef("tabs.onMoved")}} also fire for the tabs within the group.

This event doesn't fire when a tab group is moved between windows; instead, the group is removed from one window and created in another (firing {{WebExtAPIRef("tabGroups.onRemoved")}} and {{WebExtAPIRef("tabGroups.onCreated")}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This event doesn't fire when a tab group is moved between windows; instead, the group is removed from one window and created in another (firing {{WebExtAPIRef("tabGroups.onRemoved")}} and {{WebExtAPIRef("tabGroups.onCreated")}}.

This text is copied from Chrome but not true in Firefox.

Relevant discussion in https://issues.chromium.org/issues/414993460#comment8 and the whole bug report in general.


## Syntax

Expand Down
2 changes: 1 addition & 1 deletion files/en-us/mozilla/add-ons/webextensions/api/tabgroups/onremoved/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ browser-compat: webextensions.api.tabGroups.onRemoved

{{AddonSidebar}}

Fires when a tab group is removed.
Fires when a tab group is removed. This can occur when a user closes a tab group or a tab group is closed automatically because another change means it no longer contained any tabs.

## Syntax

Expand Down
2 changes: 1 addition & 1 deletion files/en-us/mozilla/add-ons/webextensions/api/tabgroups/update/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ let updatedTabGroup = await browser.tabGroups.update(
- : `integer` The ID of the tab group to update.

- `updateProperties` {{optional_inline}}
- : An object containing details of the property values to be matched in returned tab groups.
- : An object containing details of the property values to be matched in returned tab groups. Properties that aren't specified aren't modified.
- `collapsed` {{optional_inline}}
- : `boolean` Whether the tab group is collapsed or expanded in the tab strip.
- `color` {{optional_inline}}
Expand Down
Loading