Skip to content

doc[iframe/index.md]: change Window.showModalDialog() to HTMLDialogElement.showModal() #39556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

samuel871211
Copy link
Contributor

Description

Motivation

The link of Window.showModalDialog() is currently points to HTMLDialogElement.showModal()

Additional details

Related issues and pull requests

@samuel871211 samuel871211 requested a review from a team as a code owner May 18, 2025 12:24
@samuel871211 samuel871211 requested review from chrisdavidmills and removed request for a team May 18, 2025 12:24
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels May 18, 2025
Copy link
Contributor

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this, @samuel871211. LGTM!

@chrisdavidmills chrisdavidmills merged commit 0929c9a into mdn:main May 19, 2025
7 checks passed
@samuel871211 samuel871211 deleted the patch-2 branch May 20, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants