Skip to content

Fix linter reports #39651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Fix linter reports #39651

merged 1 commit into from
May 23, 2025

Conversation

Josh-Cena
Copy link
Member

Fix a few issues missed by my previous PRs, and another few that were freshly introduced a few hours ago.

@Josh-Cena Josh-Cena requested review from a team as code owners May 23, 2025 16:02
@Josh-Cena Josh-Cena requested review from sideshowbarker and removed request for a team May 23, 2025 16:02
@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs labels May 23, 2025
@Josh-Cena Josh-Cena requested review from bsmth and removed request for a team and sideshowbarker May 23, 2025 16:02
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label May 23, 2025
monitor: (monitor) => {
monitor.addEventListener("downloadprogress", (e) => {
console.log(`Downloaded ${Math.floor(e.loaded * 100)}%`);
});
},
});
}

const detector = await getDetector(["en-US", "zh"]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. (FYI @chrisdavidmills)

@@ -63,7 +63,7 @@ console.log(translation);
### Generating a translation stream

```js
const stream = translator.translateStreaming((myTextString);
const stream = translator.translateStreaming(myTextString);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one 👍🏻

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, tnx 👍🏻

@Josh-Cena Josh-Cena merged commit 3d53de8 into mdn:main May 23, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the fix-lint branch May 24, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs Content:Learn Learning area docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants