Skip to content

WebExt: cleanup useless tag of year #39731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Conversation

PassionPenguin
Copy link
Contributor

@PassionPenguin PassionPenguin commented May 29, 2025

  - : Fired when the page used the [history API (2011)](/en-US/docs/Web/API/History_API) to update the URL displayed in the browser's location bar.
  - : Fired when the page used the [history API](/en-US/docs/Web/API/History_API) to update the URL displayed in the browser's location bar.

the mark of year (2011) was added in #19644 (ref:https://github.com/mdn/content/pull/19644/files#diff-f3e7ba440cefdb995b0dcd70ea3cc161e66ce1370dde036d80941a212251fd13), which seems to be a little bit useless.

@Josh-Cena removed the first mark of year in a later cleanup, but missed? the second mark of year
(#36070, ref:https://github.com/mdn/content/pull/36070/files#diff-f3e7ba440cefdb995b0dcd70ea3cc161e66ce1370dde036d80941a212251fd13)

per @yin1999's suggestion and my perspective, may the second tag be removed as well as it seems to be a little bit useless here?

@PassionPenguin PassionPenguin requested a review from a team as a code owner May 29, 2025 14:33
@PassionPenguin PassionPenguin requested review from Rob--W and removed request for a team May 29, 2025 14:33
@github-actions github-actions bot added Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed labels May 29, 2025
Copy link
Contributor

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) I was only interested in updating the link in that PR, so I didn't search for other places.

@Josh-Cena Josh-Cena merged commit e92bec8 into mdn:main May 29, 2025
7 checks passed
@PassionPenguin PassionPenguin deleted the patch-5 branch May 30, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebExt WebExtensions docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants