-
Notifications
You must be signed in to change notification settings - Fork 22.8k
FF141 Relnote/Expr Feat closedBy/closedby on dialogs #40036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+3
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
9732400
to
38d136f
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
38d136f
to
a4992ce
Compare
a4992ce
to
cf8c5e1
Compare
Can you please review this one too @pepelsbey |
dipikabh
approved these changes
Jul 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, just few nits for you to review. Thank you!
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
67625d1
to
9553ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FF141 adds support for
HTMLDialogElement.closedBy
andclosedby
attribute on<dialog>
by default in https://bugzilla.mozilla.org/show_bug.cgi?id=1964078This adds a release note and removes the experimental feature note.
Related docs work can be tracked in #40028