-
Notifications
You must be signed in to change notification settings - Fork 22.8k
List Translator and Language Detector APIs restricted to secure contexts #40307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Translator and Language Detector APIs restricted to secure contexts #40307
Conversation
files/en-us/web/security/secure_contexts/features_restricted_to_secure_contexts/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
FYI @chrisdavidmills and @tomayac |
@michaelwasserman Thankyou for this. A bit more had to be done, which was adding the secure context headers. I've added to overview page, properties, methods.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a non-owner
Thanks for the additional fixes! Everything lgtm, responses:
AFAIK, the entire interface and everything therein is SecureContext in spec and impl.
I did a pass over the live pages and changes. This looks complete, thank you!
This seems to be a documentation discrepancy, the interfaces themselves have been SecureContext from initial spec work, and before Chrome origin trials and launches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelwasserman @tomayac Thanks both of you for confirmations and for reporting. This is good to go!
Description
List Translator and Language Detector APIs restricted to secure contexts
Motivation
Match the Spec:
https://webmachinelearning.github.io/translation-api/#translator-api
https://webmachinelearning.github.io/translation-api/#language-detector-api
Additional details
Perhaps the API docs should also be updated?
https://developer.mozilla.org/en-US/docs/Web/API/Translator_and_Language_Detector_APIs
Related issues and pull requests
Reported via Chromium issue:
https://issues.chromium.org/u/1/issues/428561254