Skip to content

Internalize DataTransfer.files example #40316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 11, 2025
Merged

Internalize DataTransfer.files example #40316

merged 5 commits into from
Jul 11, 2025
+47 −6

Conversation

Josh-Cena
Copy link
Member

Part of #16120. Right now there are two links, but the code in these two playgrounds are exactly identical.

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 11, 2025 08:27
@Josh-Cena Josh-Cena requested review from sideshowbarker and bsmth and removed request for a team July 11, 2025 08:27
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

Preview URLs

(comment last updated: 2025-07-11 16:08:14)

bsmth
bsmth reviewed Jul 11, 2025
View reviewed changes
bsmth
bsmth reviewed Jul 11, 2025
View reviewed changes
bsmth
bsmth reviewed Jul 11, 2025
View reviewed changes
bsmth
bsmth reviewed Jul 11, 2025
View reviewed changes
@bsmth bsmth removed the request for review from sideshowbarker July 11, 2025 11:20
bsmth
bsmth approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. First I though log was typo for console.log but we're just missing the log function. Other minor suggestions, but I think we're good once you had a look 👍🏻

Josh-Cena
Josh-Cena commented Jul 11, 2025
View reviewed changes
@Josh-Cena @bsmth
Apply suggestions from code review
c4d66bf 
Co-authored-by: Brian Smith <brian@smith.berlin>
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 11, 2025
github-actions[bot]
github-actions bot reviewed Jul 11, 2025
View reviewed changes
@bsmth @github-actions
Update files/en-us/web/api/datatransfer/files/index.md
6810326 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bsmth
bsmth reviewed Jul 11, 2025
View reviewed changes
@Josh-Cena @bsmth
Update files/en-us/web/api/datatransfer/files/index.md
0e8d79f 
Co-authored-by: Brian Smith <brian@smith.berlin>
@Josh-Cena
Copy link
Member Author

Thanks for the great suggestions @bsmth!

@Josh-Cena Josh-Cena merged commit 9d5666d into mdn:main Jul 11, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the datatransfer-files-ex branch July 11, 2025 16:09
@bsmth
Copy link
Member

bsmth commented Jul 11, 2025

Thanks for the great suggestions @bsmth!

Looking great, thanks a lot 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @bsmth