Skip to content

Replace all JSBin links in audio/video delivery section #40335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 15, 2025

Conversation

Josh-Cena
Copy link
Member

Part of #16120. Instead of JPlayer, I'm using shared-assets instead due to CSP issues.

@Josh-Cena Josh-Cena requested a review from a team as a code owner July 13, 2025 04:17
@Josh-Cena Josh-Cena requested review from hamishwillee and bsmth and removed request for a team and hamishwillee July 13, 2025 04:17
@github-actions github-actions bot added Content:Media Media docs size/m [PR only] 51-500 LoC changed labels Jul 13, 2025
Copy link
Contributor

github-actions bot commented Jul 13, 2025

Preview URLs

External URLs (6)

URL: /en-US/docs/Web/Media/Guides/Audio_and_video_delivery
Title: Audio and video delivery

(comment last updated: 2025-07-15 15:12:58)

audio.buffered.start(audio.buffered.length - 1 - i) < audio.currentTime
) {
document.getElementById("buffered-amount").style.width = `${
(audio.buffered.end(audio.buffered.length - 1 - i) * 100) / duration
Copy link
Member

@bsmth bsmth Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the buffered amount (light-grey) in this example, but it works on the jsbin. Played (green, progress-amount) looks okay to me, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, not sure why

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because we're using the cached versions so there's nothing to download between test runs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's showing up for me now, so I think it's good

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to check, mostly the buffering / seeking examples need another look to get working. Nothing else major.

@Josh-Cena Josh-Cena requested a review from bsmth July 15, 2025 13:10
…_playbackrate_explained/index.md

Co-authored-by: Brian Smith <brian@smith.berlin>
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, there's a small edge case to cover regarding loading / buffered cached things, but that's not blocking

@Josh-Cena
Copy link
Member Author

Yeah idk how to fix that and if we should -_-

@Josh-Cena Josh-Cena merged commit a318c45 into mdn:main Jul 15, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the av-delivery-ex branch July 15, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Media Media docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants