-
Notifications
You must be signed in to change notification settings - Fork 22.8k
Replace all JSBin links in audio/video delivery section #40335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URLs
External URLs (6)URL:
(comment last updated: 2025-07-15 15:12:58) |
files/en-us/web/media/guides/audio_and_video_delivery/buffering_seeking_time_ranges/index.md
Show resolved
Hide resolved
files/en-us/web/media/guides/audio_and_video_delivery/buffering_seeking_time_ranges/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/media/guides/audio_and_video_delivery/buffering_seeking_time_ranges/index.md
Outdated
Show resolved
Hide resolved
audio.buffered.start(audio.buffered.length - 1 - i) < audio.currentTime | ||
) { | ||
document.getElementById("buffered-amount").style.width = `${ | ||
(audio.buffered.end(audio.buffered.length - 1 - i) * 100) / duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the buffered amount (light-grey) in this example, but it works on the jsbin. Played (green, progress-amount
) looks okay to me, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, not sure why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's because we're using the cached versions so there's nothing to download between test runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's showing up for me now, so I think it's good
files/en-us/web/media/guides/audio_and_video_delivery/webaudio_playbackrate_explained/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things to check, mostly the buffering / seeking examples need another look to get working. Nothing else major.
files/en-us/web/media/guides/audio_and_video_delivery/webaudio_playbackrate_explained/index.md
Outdated
Show resolved
Hide resolved
…_playbackrate_explained/index.md Co-authored-by: Brian Smith <brian@smith.berlin>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, there's a small edge case to cover regarding loading / buffered cached things, but that's not blocking
Yeah idk how to fix that and if we should -_- |
Part of #16120. Instead of JPlayer, I'm using shared-assets instead due to CSP issues.