response.bodyUsed: Fix bad URL, update syntax #40337
Merged
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bad image URL: - The URL used in the example (an image on a Mediawiki server) was no longer valid. For future-proofing, seems better to use a local image URL. - Add width=200 to `<img>` tag, because the new image is an SVG that will otherwise render overpoweringly large. Update code: - Remove the trailing / in the `<img>` tag, because we're writing HTML not XML. - Replace the non-conforming use of `<br />` to separate thematic elements with enclosing `<p>` tags around each thematic element. - Replace arbitrary, gratuitous use of `<pre>` with `<p>` tags.
github-actions
bot
added
Content:WebAPI
ferdnyc
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Preview URLs (comment last updated: 2025-07-13 09:41:19) |
Further reduce the image width to 150, so that the example doesn't exceed the embedded content area even when all elements are visible. (With width=200, the text added below the image on subsequent clicks would extend slightly past the bottom of the container.)
Josh-Cena
reviewed
Jul 13, 2025
Josh-Cena
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace bad image URL:
width=150to<img>tag, because the new image is an SVG that will otherwise render overpoweringly large. Update code:Remove the trailing / in the(Linter decided it likes<img>tag, because we're writing HTML not XML.<img ... />.)<br />to separate thematic elements with enclosing<p>tags around each thematic element.Replace arbitrary, gratuitous use of<pre>with<p>tags.Description
The URL used in the example (an image on a Mediawiki server) was no longer valid. Also, the code was... quite outdated, by current web standards.
Motivation
Examples are more effective when they successfully demonstrate the features being documented, which a broken image placeholder doesn't really accomplish. Ditto, code that demonstrates recent web standards and practices, rather than flaunting them.
Additional details
Related issues and pull requests