Skip to content

feat: move Quick_Links into front matter #40370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jul 15, 2025

Description

For the "Related" and "IMSC" sections:

  • Add yaml sidebars
  • Use front matter sidebars
  • Remove Quick_links

Motivation

We're setting sidebars in front matter.

@bsmth bsmth requested review from a team as code owners July 15, 2025 10:31
@bsmth bsmth requested review from chrisdavidmills and pepelsbey and removed request for a team July 15, 2025 10:31
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:Events Events docs size/m [PR only] 51-500 LoC changed labels Jul 15, 2025
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO: if we think this "related" thing is a good idea (which I'm skeptical) and we plan to add more stuff here, then we should have a new sidebar for each technology, just like the API area, because it will necessarily be ever-growing. Then the "Related" page itself would not have a sidebar, just like the status quo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we think this "related" thing is a good idea

We don't :) -> we are likely going to move the IMSC docs elsewhere (into Media?). We need to discuss again, but that would make this section redundant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds better :)

@bsmth
Copy link
Member Author

bsmth commented Jul 15, 2025

Thanks, merging shortly 👍🏻

@bsmth bsmth merged commit 95e0fbb into mdn:main Jul 15, 2025
7 checks passed
@bsmth bsmth deleted the missing-sidebars branch July 15, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Events Events docs Content:Other Any docs not covered by another "Content:" label size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants