Skip to content

Fix content issues #40371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Fix content issues #40371

merged 1 commit into from
Jul 15, 2025

Conversation

Josh-Cena
Copy link
Member

Broken links, poor CSS semantics, inline script

@Josh-Cena Josh-Cena requested review from a team as code owners July 15, 2025 12:07
@Josh-Cena Josh-Cena requested review from chrisdavidmills, wbamberg and bsmth and removed request for a team, chrisdavidmills and wbamberg July 15, 2025 12:07
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed labels Jul 15, 2025
Copy link
Contributor

Preview URLs (6 pages)
Flaws (4)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document_Object_Model/Reflected_attributes
Title: Attribute reflection
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/API/Document_Object_Model/Events which is a redirect
    • Macro produces link /en-US/docs/Web/API/Document_Object_Model/Whitespace_in_the_DOM which is a redirect

URL: /en-US/docs/Web/CSS/if
Title: if()
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/linear-gradient which is a redirect
  • unknown:
    • Parse error: Unexpected input
External URLs (5)

URL: /en-US/docs/Learn_web_development/Extensions/Server-side/Express_Nodejs/Introduction
Title: Express/Node introduction


URL: /en-US/docs/Web/API/WebGL_API
Title: WebGL: 2D and 3D graphics for the web


URL: /en-US/docs/Web/JavaScript/Guide/Using_promises
Title: Using promises


URL: /en-US/docs/Web/JavaScript/Reference/Statements/function*
Title: function*

@@ -35,7 +35,7 @@ This convention has several advantages. We will explore each one.

## Chaining

A common need is to execute two or more asynchronous operations back to back, where each subsequent operation starts when the previous operation succeeds, with the result from the previous step. In the old days, doing several asynchronous operations in a row would lead to the classic [callback hell](http://callbackhell.com/):
A common need is to execute two or more asynchronous operations back to back, where each subsequent operation starts when the previous operation succeeds, with the result from the previous step. In the old days, doing several asynchronous operations in a row would lead to the classic [callback hell](https://medium.com/@raihan_tazdid/callback-hell-in-javascript-all-you-need-to-know-296f7f5d3c1):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it gone? :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the website is no longer there

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

@Josh-Cena Josh-Cena merged commit d8a5165 into mdn:main Jul 15, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the fix-content branch July 15, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:JS JavaScript docs Content:Learn Learning area docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants