Make test your skills boilerplate more consistent #40447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
chrisdavidmills
requested review from
bsmth
and removed request for
a team and
wbamberg
bsmth
reviewed
Jul 21, 2025
bsmth
reviewed
Jul 21, 2025
.../en-us/learn_web_development/core/accessibility/test_your_skills/css_and_javascript/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jul 21, 2025
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
bsmth
reviewed
Jul 21, 2025
files/en-us/learn_web_development/core/css_layout/test_your_skills/flexbox/index.md
Outdated
Show resolved
Hide resolved
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
size/xl
bsmth
reviewed
Jul 23, 2025
| @@ -329,3 +303,5 @@ item.addEventListener("keyup", (e) => { | |||
| ``` | |||
|
|
|||
| </details> | |||
|
|
|||
| | |||
There was a problem hiding this comment.
Is this to create some padding between the feedback box and the end of the article? I think this is fixed in the new frontend, so better to avoid it
There was a problem hiding this comment.
Yes, that is exactly right ;-)
I'll remove them, in that case.
bsmth
reviewed
Jul 23, 2025
| If you make a mistake, you can clear your work using the Reset button in the MDN Playground. If you get really stuck, you can (usually) view the solution at the bottom of each question section, or [reach out for help](#contact_us). | ||
|
|
||
| > [!NOTE] | ||
| > If you'd prefer to work in your own editor or in an online editor (such as [CodePen](https://codepen.io/) or [JSFiddle](https://jsfiddle.net/)), you can feel free to copy the code from the MDN Playground into your chosen environment. |
There was a problem hiding this comment.
Lovely
Suggested change
| > If you'd prefer to work in your own editor or in an online editor (such as [CodePen](https://codepen.io/) or [JSFiddle](https://jsfiddle.net/)), you can feel free to copy the code from the MDN Playground into your chosen environment. | |
| > If you'd prefer to work in your own editor or in an online editor (such as [CodePen](https://codepen.io/) or [JSFiddle](https://jsfiddle.net/)), you can copy the code from the MDN Playground into your chosen environment. |
bsmth
reviewed
Jul 23, 2025
| > [!NOTE] | ||
| > If you'd prefer to work in your own editor or in an online editor (such as [CodePen](https://codepen.io/) or [JSFiddle](https://jsfiddle.net/)), you can feel free to copy the code from the MDN Playground into your chosen environment. | ||
|
|
||
| Some questions don't feature in-page starting code, and instead ask you to download starter files to work on your local machine with. Sometimes this is due to the complex nature of the question, and sometimes we just wanted to change things up a bit. |
There was a problem hiding this comment.
Suggested change
| Some questions don't feature in-page starting code, and instead ask you to download starter files to work on your local machine with. Sometimes this is due to the complex nature of the question, and sometimes we just wanted to change things up a bit. | |
| Some questions don't include code blocks to start from, and instead ask you to download starter files to work on your local machine with. Sometimes this is due to the complex nature of the question, and sometimes we just wanted to change things up a bit. |
bsmth
approved these changes
Jul 23, 2025
Woo hoo! Cheers @bsmth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the following comments:
This PR attempts to make all the "test your skills" boilerplate a bit more consistent.
This is quite a lot to review, so apologies, but it should be a matter of looking at a few to make sure the boilerplate looks OK, and then skimming the live pages to make sure nothing looks broken.
Motivation
Additional details
Related issues and pull requests