Skip to content

fix(glossary): Add cross references between browser glossary pages #40514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025

Conversation

dipikabh
Copy link
Contributor

Description

This PR primarily updates the "See also" of web browser glossary pages (Safari, Chrome, Firefox, Edge, Opera, and IE) to add cross-references between all browser entries.

Inspired by the links in Safari's See also section, this PR adds similar links to "See also"s on Chrome and Firefox pages.

Motivation

To make the relevant pages discoverable from any and all browser glossary pages.

@dipikabh dipikabh requested a review from a team as a code owner July 24, 2025 02:00
@dipikabh dipikabh requested review from hamishwillee and removed request for a team July 24, 2025 02:00
@github-actions github-actions bot added Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Preview URLs (7 pages)
External URLs (35)

URL: /en-US/docs/Glossary/Apple_Safari
Title: Apple Safari


URL: /en-US/docs/Glossary/Browser
Title: Browser


URL: /en-US/docs/Glossary/Google_Chrome
Title: Google Chrome


URL: /en-US/docs/Glossary/Microsoft_Edge
Title: Microsoft Edge


URL: /en-US/docs/Glossary/Microsoft_Internet_Explorer
Title: Microsoft Internet Explorer


URL: /en-US/docs/Glossary/Mozilla_Firefox
Title: Mozilla Firefox


URL: /en-US/docs/Glossary/Opera_Browser
Title: Opera browser

(comment last updated: 2025-08-15 15:32:26)

@dipikabh
Copy link
Contributor Author

Thanks a lot for reviewing, Hamish! This completely fell off my radar.
I've fixed your comments, it's ready for another look.

@dipikabh dipikabh requested a review from hamishwillee August 13, 2025 00:34
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me thanks. I've made a suggestion in https://github.com/mdn/content/pull/40514/files#r2277936794 that you might want to take or modify ... or perhaps not (and roll out in the other marked places).
Approving so you can merge after whatever you decide.

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
@dipikabh
Copy link
Contributor Author

Thank you! I like the suggestion. Merging after applying to all instances.

@dipikabh dipikabh merged commit ac287b7 into mdn:main Aug 15, 2025
8 checks passed
estelle pushed a commit that referenced this pull request Aug 19, 2025
…40514)

* add cross links between browser glossaries

* fix review feedback

* Apply suggestions from code review

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>

---------

Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Glossary Glossary entries size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants