Skip to content

Migrate all images with editable source to shared-assets #40524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Migrate all images with editable source to shared-assets #40524

merged 1 commit into from
Jul 24, 2025

Conversation

Josh-Cena
Copy link
Member

This migrates all .drawio and .html assets over, so they can be managed in a central place, and also enables deduplication.

I'm also changing SVG to PNG. SVG generated from draw.io is very cool because it supports dark mode OOTB on MDN :)

See mdn/shared-assets#57

@Josh-Cena Josh-Cena requested review from a team as code owners July 24, 2025 13:41
@Josh-Cena Josh-Cena requested review from hamishwillee, chrisdavidmills and sideshowbarker and removed request for a team July 24, 2025 13:41
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:HTTP HTTP docs labels Jul 24, 2025
@Josh-Cena Josh-Cena requested review from bsmth and removed request for a team, hamishwillee, chrisdavidmills and sideshowbarker July 24, 2025 13:41
@github-actions github-actions bot added the size/xl [PR only] >1000 LoC changed label Jul 24, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs (10 pages)
Flaws (15)

URL: /en-US/docs/Learn_web_development/Core/Structuring_content/Structuring_documents
Title: Structuring documents
Flaw count: 2

  • unknown:
    • Error parsing /shared-assets/images/diagrams/learn/structuring-documents/site-structure.svg: No such file or directory (os error 2)
    • Error parsing /shared-assets/images/diagrams/learn/structuring-documents/site-map.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/API/Attribution_Reporting_API
Title: Attribution Reporting API
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/api/attribution-reporting/ara-flow.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/API/Window_Management_API/Multi-screen_origin
Title: Multi-screen origin
Flaw count: 2

  • unknown:
    • Error parsing /shared-assets/images/diagrams/api/window-management/primary-screen-left.svg: No such file or directory (os error 2)
    • Error parsing /shared-assets/images/diagrams/api/window-management/primary-screen-right.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/CSS_anchor_positioning/Using
Title: Using CSS anchor positioning
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/anchor-positioning/position-area.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/CSS_overflow/CSS_carousels
Title: Creating CSS carousels
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/carousels/carousel.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/CSS/position-area
Title: position-area
Flaw count: 1

  • unknown:
    • Error parsing /shared-assets/images/diagrams/css/anchor-positioning/position-area.svg: No such file or directory (os error 2)

URL: /en-US/docs/Web/HTML/Reference/Elements/td
Title: <td>: The Table Data Cell element
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/diagrams/html/table/column-row-span.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/HTML/Reference/Elements/th
Title: <th>: The Table Header element
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/diagrams/html/table/column-row-span.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/HTML/Reference/Elements/thead
Title: <thead>: The Table Head element
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/diagrams/html/table/column-row-span.png: No such file or directory (os error 2)

URL: /en-US/docs/Web/HTTP/Guides/Cookies
Title: Using HTTP cookies
Flaw count: 4

  • unknown:
    • Error opening /shared-assets/images/diagrams/http/cookies/cookie-basic-example.png: No such file or directory (os error 2)
    • No generic content config found
    • no blog root
    • no blog root

bsmth
bsmth approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you 🙏🏻

@Josh-Cena Josh-Cena merged commit f5fd477 into mdn:main Jul 24, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the share-assets branch July 24, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Learn Learning area docs Content:WebAPI Web API docs size/xl [PR only] >1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @bsmth