Skip to content

Fix content issues #40536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

Fix content issues #40536

merged 2 commits into from
Jul 28, 2025

Conversation

Josh-Cena
Copy link
Member

Fix bad code, bad link, and missing sidebar.

@Josh-Cena Josh-Cena requested review from a team as code owners July 26, 2025 07:00
@Josh-Cena Josh-Cena requested review from estelle and wbamberg and removed request for a team July 26, 2025 07:00
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:Media Media docs size/m [PR only] 51-500 LoC changed labels Jul 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 26, 2025 •
edited
Loading

Preview URLs (10 pages)
Flaws (5)

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/IdentityCredential/disconnect_static
Title: IdentityCredential: disconnect() static method
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US//docs/Web/API/FedCM_API/IDP_integration#disconnect_endpoint
  • unknown:
    • No generic content config found
    • no blog root
    • no blog root

URL: /en-US/docs/Web/CSS/:active-view-transition
Title: :active-view-transition
Flaw count: 1

  • macros:
    • Can't resolve /en-US/docs/Web/CSS/:active-view-transition-type
External URLs (2)

URL: /en-US/docs/Web/API/ConvolverNode
Title: ConvolverNode

URL: /en-US/docs/Web/Media/Guides/Audio_and_video_manipulation
Title: Audio and video manipulation

(comment last updated: 2025-07-28 17:43:27)

@sideshowbarker sideshowbarker removed the request for review from a team July 26, 2025 10:39
dipikabh
dipikabh approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@Josh-Cena @dipikabh
Update files/en-us/web/api/convolvernode/index.md
469e3a1 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@Josh-Cena Josh-Cena merged commit 90e5b79 into mdn:main Jul 28, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-content branch July 30, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Media Media docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @dipikabh