Skip to content

40483 heading selectors #40784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Aug 19, 2025
Merged

40483 heading selectors #40784

merged 45 commits into from
Aug 19, 2025

Conversation

dletorey
Copy link
Contributor

Description

  • Re-opened the PR:
    • to fix an error about role=heading
    • to close a CSS code block
  • Created page for :heading pseudo-class
  • Created page for :heading() functional pseudo-class
  • Added both to the pseudo-classes page

Motivation

Related issues and pull requests

dletorey and others added 30 commits August 5, 2025 16:51
@dletorey
added the :heading and :heading pages
c3ebe9a
@dletorey
Merge branch 'main' into 40483-heading-selectors
c06d7bc
@dletorey
finshed the :heading & :heading() pages
dd69d01
@dletorey
added note to :heading() and added both to pseudo-classes page
169f663
@dletorey
Merge branch 'main' into 40483-heading-selectors
af829de
@dletorey @github-actions
Update files/en-us/web/css/_colon_heading_function/index.md
10ceb0a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey @github-actions
Update files/en-us/web/css/_colon_heading_function/index.md
e96bf2a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey @github-actions
Update files/en-us/web/css/_colon_heading_function/index.md
984b927 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey
made explanation match code example
917d7f8
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
531fb9f 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
77ac648 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
0630303 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
d2d981e 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
a862da4 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
396f6b5 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
70af4d7 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
2b93476 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
1030607 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
f258db7 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
d587432 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @github-actions
Update files/en-us/web/css/_colon_heading/index.md
96c21f7 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey
Merge branch 'main' into 40483-heading-selectors
2667e9e
@dletorey
fixed code blocks
1248fc1
@dletorey
Merge branch 'main' into 40483-heading-selectors
faa1fc0
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
ba72433 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey
updated the Note & parameters
1cb2752
@dletorey
Merge branch '40483-heading-selectors' of github.com:dletorey/content…
9944d0c 
… into 40483-heading-selectors
@dletorey
fixed the syntax example
0c962f8
@dletorey
added a note about matching attributes
1ef85b8
@dletorey
moved the note to usage notes
8070f80
dletorey and others added 11 commits August 11, 2025 15:52
@dletorey
Merge branch 'main' into 40483-heading-selectors
bf5bdc8
@dletorey
Merge branch 'main' into 40483-heading-selectors
a7d3ed4
@caugner
Merge branch 'main' into 40483-heading-selectors
714d935
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading/index.md
c5f8d28 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
0979834 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
0ed3a0f 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
a2bce13 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
1587bc1 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey @dipikabh
Update files/en-us/web/css/_colon_heading_function/index.md
6104a30 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@dletorey
Merge branch 'main' into 40483-heading-selectors
509583b
@dletorey
fixed the code block not ending and the example of aria roles
3e36ea9
@dletorey dletorey requested a review from a team as a code owner August 18, 2025 14:33
@dletorey dletorey requested review from estelle and removed request for a team August 18, 2025 14:33
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Aug 18, 2025
@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/m [PR only] 51-500 LoC changed labels Aug 18, 2025
@dletorey dletorey mentioned this pull request Aug 18, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025 •
edited
Loading

Preview URLs

(comment last updated: 2025-08-19 09:12:16)

@dletorey dletorey mentioned this pull request Aug 18, 2025
Closed
8 tasks
estelle
estelle approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion. approving to not hold you up

@dletorey dletorey merged commit 1eeaa8c into mdn:main Aug 19, 2025
8 checks passed
@dletorey dletorey deleted the 40483-heading-selectors branch August 19, 2025 09:11
@dletorey dletorey mentioned this pull request Aug 19, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estelle estelle estelle approved these changes

@Josh-Cena Josh-Cena Josh-Cena left review comments

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dletorey @estelle @Josh-Cena @caugner