fix(search): close when clicking backdrop cross-browser #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
90938f2 was deployed to: https://fred-pr436.review.mdn.allizom.net/ |
Rumyra
approved these changes
Jul 18, 2025
pepelsbey
approved these changes
Jul 18, 2025
|
@pepelsbey latest commit should fix that (tested in Epiphany) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
closedbyattribute on<dialog>allows us to close these (including the search) by clicking on the backdrop, but this doesn't work in Firefox Release (only Firefox Nightly). https://github.com/tak-dcxi/dialog-closedby-polyfill fixes this, but it's a bit heavy - and really covers all edge cases, which we don't use - so I cut it down a lot, and included only what we needTested in Firefox Release/Nightly and Chrome: would be great to get a test in Safari too