-
Notifications
You must be signed in to change notification settings - Fork 9
enhance(font): remove ligatures from JB Mono #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
14a0328 was deployed to: https://fred-pr437.review.mdn.allizom.net/ |
@LeoMcA let me know if the instructions are clear enough to reproduce the non-ligature font. |
@pepelsbey would be great to specify either the commit that patch currently works against, or the "method" taken (is it just deleting everything out of the "calt" block), or both - will help in the future if we have to apply this again against and updated font |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job: a little more clarity about the approach taken to remove ligatures and/or the commit hash that patch applies cleanly against would be great, as commented above
Also a couple more font-feature-settings
which can go:
font-feature-settings: "calt" 0; |
fred/components/code-example/common.css
Line 43 in 0aeb772
font-feature-settings: "calt" 0; |
Description
Replaces JB Mono source files with the new ones compiled without ligatures from the source.
Saves some weight for WOFF files as well.