Skip to content

enhance(font): remove ligatures from JB Mono #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 23, 2025
Merged

Conversation

pepelsbey
Copy link
Member

Description

Replaces JB Mono source files with the new ones compiled without ligatures from the source.

Saves some weight for WOFF files as well.

Copy link
Contributor

github-actions bot commented Jul 18, 2025

14a0328 was deployed to: https://fred-pr437.review.mdn.allizom.net/

@pepelsbey pepelsbey requested a review from a team as a code owner July 21, 2025 11:09
@pepelsbey
Copy link
Member Author

@LeoMcA let me know if the instructions are clear enough to reproduce the non-ligature font.

@LeoMcA
Copy link
Member

LeoMcA commented Jul 21, 2025

@pepelsbey would be great to specify either the commit that patch currently works against, or the "method" taken (is it just deleting everything out of the "calt" block), or both - will help in the future if we have to apply this again against and updated font

Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job: a little more clarity about the approach taken to remove ligatures and/or the commit hash that patch applies cleanly against would be great, as commented above

Also a couple more font-feature-settings which can go:

font-feature-settings: "calt" 0;

font-feature-settings: "calt" 0;

@pepelsbey pepelsbey merged commit dfd318b into main Jul 23, 2025
7 checks passed
@pepelsbey pepelsbey deleted the code-font-rm-ligatures branch July 23, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants