fix: randomize button label ids to prevent leaking non-unique element ids #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

argl wants to merge 1 commit into main from button-ids

Contributor

argl commented Jul 25, 2025

Description

The button component potentially leaked element ids, this fixes it.

Motivation

Proper HTML markup


          randomize button ids

08113ec

argl deployed to review

July 25, 2025 15:12

— with

GitHub Actions View deployment

Contributor

github-actions bot commented Jul 25, 2025

8350d9f was deployed to: https://fred-pr455.review.mdn.allizom.net/

Member

pepelsbey commented Jul 25, 2025

I wonder if we could use randomUUID() for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet