Vector pa kernels #4861
Draft
Vector pa kernels #4861
+1,655
−1,055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VectorDiagonalPA tests
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the partial assembly (PA) kernels for vector integrators by adding support for vector and matrix coefficients, updating test cases to use parameter generation for higher-dimensional tests, and introducing new shared memory kernel implementations. Key changes include:
- Updated and refactored PA kernel tests in both mass and diffusion integrators.
- New support for coefficient types and shared memory kernels in vector PA implementations.
- Registration of new kernels and corresponding updates in the build configurations.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/fem/test_pa_kernels.cpp | Updated test functions to use GENERATE for dynamic dimensions and improved coefficient tests. |
| tests/unit/fem/test_pa_diagonal.cpp | Refactored diagonal PA tests with clearer parameter generation and cast improvements. |
| tests/unit/CMakeLists.txt | Modified unit test registrations to remove obsolete tests and add new PA diagonal tests. |
| linalg/tensor.hpp | Introduced template specializations and updated literal usage for improved type safety. |
| general/nvtx.hpp | Added inclusion of NVTX header for performance debugging. |
| fem/integ/bilininteg_vecmass_pa.hpp | New implementation for vector mass PA kernels supporting various coefficient types. |
| fem/bilininteg.hpp | Registered new PA kernel function types for VectorMass and VectorDiffusion integrators. |
| fem/bilininteg.cpp | Minor formatting update (removed extra blank line). |
| fem/CMakeLists.txt | Added new integrator kernel headers to the build configuration. |
Comments suppressed due to low confidence (1)
tests/unit/fem/test_pa_kernels.cpp:359
- [nitpick] The function name 'test_vker_pa' may be less descriptive than the previous 'test_vector_pa_integrator'. Consider renaming it for clarity.
real_t test_vker_pa(int dim)
…tor into same kernel
Fix couple of warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances PA
VectorMassIntegratorandVectorDiffusionIntegrator:VectorCoefficientandMatrixCoefficientVectorMassAddMultPAandVectorDiffusionAddMultPAin the kernel mapsEval/Gradmethods for higher-order support beyondDofQuadLimits