Skip to content

Expand MCP Workbench to support more MCP Client features #6785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tylerpayne
Copy link

@tylerpayne tylerpayne commented Jul 9, 2025

Why are these changes needed?

MCP Servers can request sampling from the MCP Host/Client's LLM.

Also exposed additional MCP ClientSession methods for listing and reading/getting prompts, resources, and resourceTemplates. This makes the McpWorkbench more like a full MCP Client.

Related issue number

N/A

Checks


Thoughts @ekzhu @victordibia ?

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 47.23926% with 86 lines in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (25d7328) to head (19dc024).

Files with missing lines Patch % Lines
...es/autogen-ext/src/autogen_ext/tools/mcp/_actor.py 56.12% 43 Missing ⚠️
...utogen-ext/src/autogen_ext/tools/mcp/_workbench.py 32.81% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6785      +/-   ##
==========================================
- Coverage   80.40%   80.09%   -0.31%     
==========================================
  Files         233      233              
  Lines       17904    18050     +146     
==========================================
+ Hits        14395    14458      +63     
- Misses       3509     3592      +83     
Flag Coverage Δ
unittests 80.09% <47.23%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tylerpayne
Copy link
Author

Improving the test coverage

@victordibia
Copy link
Collaborator

Looks good and trending in the right direction.
Let me know if you'd need some help with the typing/pyright/CI steps and I can help.
I think we can build on it going forward.

Some things to consider in the future that @ekzhu and I have discussed include

  • streaming intermediate updates from long running tools. In essences tools could be agents themselves and it can be work streaming their intermediate updates so that other agents/UX can act on it. We can revisit this once MCP has a formal structure on how this should be done - see MCP proposals 776 and 383

  • improving the "bus" for user input. MCP servers already support user input requests - it can be useful to explore how teams or agents can have a central user input "bus" where these sort of elicitation requests can be piped into (instead of adding a user proxy each time). A simple solution might be to allow BaseAgent agent have a input_function of sorts.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we should go with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants