Skip to content

Version bump #11261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Version bump #11261

merged 2 commits into from
Jul 9, 2025

Conversation

ZoranPandovski
Copy link
Member

New release

Copy link

Review Summary

🏷️ Draft Comments (1)

Skipped posting 1 drafted comments based on your review threshold. Feel free to update them here.

mindsdb/interfaces/database/projects.py (1)

365-365: get_columns for knowledge base tables now hardcodes columns and omits dynamic columns from KB_TO_VECTORDB_COLUMNS, which may cause missing or incorrect columns if the knowledge base schema changes.

Scores:

  • Production Impact: 2
  • Fix Specificity: 2
  • Urgency Impact: 2
  • Total Score: 6

Reason for filtering: The commitable suggestion references KB_TO_VECTORDB_COLUMNS which is not imported in the file and may not exist. The comment assumes a 'previous implementation' that cannot be verified from the current code. While the hardcoded columns issue is real, the proposed solution is technically unverifiable and potentially incorrect.

Analysis: The comment correctly identifies hardcoded columns on line 365, but the suggested fix references an unimported constant that may not exist. The assumption about a 'previous implementation' cannot be verified, making the technical accuracy questionable despite identifying a real maintainability concern.


@ZoranPandovski ZoranPandovski merged commit ce9dee8 into main Jul 9, 2025
23 checks passed
@ZoranPandovski ZoranPandovski deleted the new-release branch July 9, 2025 09:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants