Skip to content

utils: fix broken symlink copy exception #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
utils: fix broken symlink copy exception
  • Loading branch information
Karneades committed Jul 29, 2024
commit bc2fd1a2aeac64bfca71f32a96103b6c6c596ba6
5 changes: 5 additions & 0 deletions docs/about/release-notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ The current and past members of the MkDocs team.
* [@oprypin](https://github.com/oprypin/)
* [@ultrabug](https://github.com/ultrabug/)

## Version 1.6.1 (2024-07-??)

* Fix copy failure due to broken symlinks. Provide warning if symlink is not
available, but continue copy instead of exception.

## Version 1.6.0 (2024-04-20)

### Local preview
Expand Down
2 changes: 1 addition & 1 deletion mkdocs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@


# For acceptable version formats, see https://www.python.org/dev/peps/pep-0440/
__version__ = '1.6.0'
__version__ = '1.6.1'
4 changes: 4 additions & 0 deletions mkdocs/utils/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,10 @@ def copy_file(source_path: str, output_path: str) -> None:
os.makedirs(output_dir, exist_ok=True)
if os.path.isdir(output_path):
output_path = os.path.join(output_path, os.path.basename(source_path))
if os.path.islink(source_path):
if not os.path.exists(os.readlink(source_path)):
log.warning( f"Symlink broken, not copy file: %s" % source_path)
return
shutil.copyfile(source_path, output_path)


Expand Down
Loading